Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change hydrostatic_delz to delz #27

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Change hydrostatic_delz to delz #27

merged 2 commits into from
Sep 25, 2024

Conversation

DavidNew-NOAA
Copy link
Contributor

@DavidNew-NOAA DavidNew-NOAA commented Sep 17, 2024 •
edited
Loading

This PR is a companion to FV3-JEDI PR #1263 and GDASApp PR #1248. It changes hydrostatic_delz to delz in the FV3 increment converter input YAMLs. See the above referenced FV3-JEDI PR for motivation and other details.

@DavidNew-NOAA DavidNew-NOAA mentioned this pull request Sep 17, 2024
Merged
@DavidNew-NOAA DavidNew-NOAA marked this pull request as ready for review September 19, 2024 16:03
@DavidNew-NOAA
Copy link
Contributor Author

I'm rolling this PR into another one, so will close it.

@DavidNew-NOAA DavidNew-NOAA reopened this Sep 23, 2024
RussTreadon-NOAA
RussTreadon-NOAA approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but changes are consistent with description.

@RussTreadon-NOAA
Copy link
Contributor

@danholdaway , if you have a chance would you take a look at this PR from @DavidNew-NOAA. We need the changes in this PR if we update the fv3-jedi hash.

@RussTreadon-NOAA
Copy link
Contributor

Confirm that combination of this PR along with GDASApp #1284 allows test_gdasapp_fv3jedi_fv3inc to pass

(gdasapp) hercules-login-3:/work/noaa/da/rtreadon/git/global-workflow/radbcor/sorc/gdas.cd/build$ ctest -R test_gdasapp_fv3jedi_fv3inc
Test project /work/noaa/da/rtreadon/git/global-workflow/radbcor/sorc/gdas.cd/build
    Start 1937: test_gdasapp_fv3jedi_fv3inc
1/1 Test #1937: test_gdasapp_fv3jedi_fv3inc ......   Passed    3.02 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   3.35 sec

Also confirmed test_gdasapp_atm_jjob Pass with these changes

(gdasapp) hercules-login-3:/work/noaa/da/rtreadon/git/global-workflow/radbcor/sorc/gdas.cd/build$ ctest -R test_gdasapp_atm_jjob
Test project /work/noaa/da/rtreadon/git/global-workflow/radbcor/sorc/gdas.cd/build
      Start 1955: test_gdasapp_atm_jjob_var_init
 1/11 Test #1955: test_gdasapp_atm_jjob_var_init .........   Passed   45.08 sec
      Start 1956: test_gdasapp_atm_jjob_var_run
 2/11 Test #1956: test_gdasapp_atm_jjob_var_run ..........   Passed   74.51 sec
      Start 1957: test_gdasapp_atm_jjob_var_inc
 3/11 Test #1957: test_gdasapp_atm_jjob_var_inc ..........   Passed   42.21 sec
      Start 1958: test_gdasapp_atm_jjob_var_final
 4/11 Test #1958: test_gdasapp_atm_jjob_var_final ........   Passed   42.17 sec
      Start 1959: test_gdasapp_atm_jjob_ens_init
 5/11 Test #1959: test_gdasapp_atm_jjob_ens_init .........   Passed   44.74 sec
      Start 1960: test_gdasapp_atm_jjob_ens_letkf
 6/11 Test #1960: test_gdasapp_atm_jjob_ens_letkf ........   Passed  810.39 sec
      Start 1961: test_gdasapp_atm_jjob_ens_init_split
 7/11 Test #1961: test_gdasapp_atm_jjob_ens_init_split ...   Passed  140.76 sec
      Start 1962: test_gdasapp_atm_jjob_ens_obs
 8/11 Test #1962: test_gdasapp_atm_jjob_ens_obs ..........   Passed   42.18 sec
      Start 1963: test_gdasapp_atm_jjob_ens_sol
 9/11 Test #1963: test_gdasapp_atm_jjob_ens_sol ..........   Passed   42.19 sec
      Start 1964: test_gdasapp_atm_jjob_ens_inc
10/11 Test #1964: test_gdasapp_atm_jjob_ens_inc ..........   Passed  170.23 sec
      Start 1965: test_gdasapp_atm_jjob_ens_final
11/11 Test #1965: test_gdasapp_atm_jjob_ens_final ........   Passed  106.20 sec

100% tests passed, 0 tests failed out of 11

Total Test time (real) = 1560.99 sec

@RussTreadon-NOAA
Copy link
Contributor

@DavidNew-NOAA and @danholdaway , I'll merge this PR into jcb-gdas develop later today (9/24) if there are no objections.

@DavidNew-NOAA
Copy link
Contributor Author

OK, thank you, @RussTreadon-NOAA

@RussTreadon-NOAA
Copy link
Contributor

Noticed that automated testing failed. Rerunning to see if checks pass on second attempt. Don't think the problem is with this PR. I suspect the issue is on the github side.

@DavidNew-NOAA
Copy link
Contributor Author

@RussTreadon-NOAA Yeah, the JCB testing has never worked for me. I just ignore it.

@RussTreadon-NOAA
Copy link
Contributor

Thanks @DavidNew-NOAA . I'll let the current testing run its course. I'll merge if it fails again.

@RussTreadon-NOAA
Copy link
Contributor

JCB client testing failed again. Given @DavidNew-NOAA's comment will proceed with merger.

@RussTreadon-NOAA RussTreadon-NOAA merged commit 272d6d7 into develop Sep 25, 2024
0 of 2 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/hydrostatic-delz branch September 25, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA approved these changes

@danholdaway danholdaway Awaiting requested review from danholdaway

@CoryMartin-NOAA CoryMartin-NOAA Awaiting requested review from CoryMartin-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidNew-NOAA @RussTreadon-NOAA